Traveling during the shoulder season has traditionally been a reliable way to save money in many destinations. But those savings are dwindling.